Use _chsize_s on Windows for truncate #24616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposal to fix #24466 . Should allow files >2 GB to be truncated on Windows.
vtjnash
reviewed
Nov 15, 2017
src/support/ios.c
Outdated
| @@ -566,7 +566,11 @@ int ios_trunc(ios_t *s, size_t size) | |||
| #if !defined(_OS_WINDOWS_) | |||
| if (ftruncate(s->fd, size) == 0) | |||
| #else | |||
| if (_chsize(s->fd, size) == 0) | |||
| #if !defined(__MINGW32__) || defined(MINGW_HAS_SECURE_API) | |||
| if (_chsize_s(s->fd, size) == 0) | |||
There was a problem hiding this comment.
I think we should just use this function everywhere. I don't see any reason we should need the alternate code path.
Checking Windows 32bit build https://julialang-s3.julialang.org/bin/winnt/x86/0.6/julia-0.6.1-win32.exe , libgit2.dll does use `_chsize_c`, so both 32bit and 64bit should be able to use `_chsize_c`.
|
Alternate code path removed. |
ararslan
added
filesystem
vtjnash
approved these changes
Nov 16, 2017
evetion
pushed a commit
to evetion/julia
that referenced
this pull request
Dec 12, 2017
Should allow files >2 GB to be truncated on Windows. Fix JuliaLang#24466 Checking Windows 32bit build https://julialang-s3.julialang.org/bin/winnt/x86/0.6/julia-0.6.1-win32.exe, libgit2.dll already uses `_chsize_s`, so both 32bit and 64bit should be able to use `_chsize_s`.
ararslan
pushed a commit
that referenced
this pull request
Apr 26, 2018
Should allow files >2 GB to be truncated on Windows. Fix #24466 Checking Windows 32bit build https://julialang-s3.julialang.org/bin/winnt/x86/0.6/julia-0.6.1-win32.exe, libgit2.dll already uses `_chsize_s`, so both 32bit and 64bit should be able to use `_chsize_s`. Ref #24616 (cherry picked from commit ff045af)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to fix #24466 . Should allow files >2 GB to be truncated on Windows.